Open
Conversation
Add Fish shell integration code with Ctrl+O hotkey binding. The integration includes visual feedback with an hourglass icon during processing, and retains the original prompt as a comment for easy reference (easily removed with Ctrl+K).
Now, `sgpt --install_shell_integration` works on Fish shell.
Author
|
Hi @TheR1D Bumping this PR as it's been a few months. I believe Fish shell support is still a highly requested feature (fixes #447). The code is ready for review. I'm happy to rebase this onto the latest main and address any feedback you or the other maintainers might have to get this across the finish line. Is there anything specific you'd like me to adjust? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Fish shell integration support to shell_gpt, implementing the functionality requested in issue #447.
Changes
sgpt/integration.pysgpt --install_shell_integrationto work with Fish shell insgpt/app.pyandsgpt/utils.pyFeatures
Testing
The integration has been tested with Fish shell and works as expected with the standard shell_gpt workflow.
Fixes #447