-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New lesson: JSON Web Tokens #29711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New lesson: JSON Web Tokens #29711
Conversation
No need for a full handholdy tutorial. Just highlight the differences between stateful/stateless and session/JWT
req.headers is a Node built-in getter as part of the Message interface (which extends Request). Not as intuitive to find docs for since people will likely look at the Request interface first. It'll be easier for learners to find an Express method in Express docs - consistent with other Express methods used in this and other lessons.
More detail left for a future Sessions vs JWTs lesson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Various grammar and tonal improvements.
Co-authored-by: Kevin Browne <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking real good, just a few comments below
Content to be covered in a later planned lesson.
Closer parallel with sessions example, only omitting DB query for session
7f8ab31
to
b546d37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
@01zulfi Just realised with the caveats section gone, there's nothing about logging out with stateless auth. Added a little bit about logging out but leaving the caveat details for the comparison lesson. This little bit should be sufficient and allow the learner to figure out what code they might need based on the mechanism. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
Because
As part of the Node revamp's 2nd milestone
This PR
Issue
Closes #29519
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section