-
Notifications
You must be signed in to change notification settings - Fork 0
Release mcpx webapp tests #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
| for IMAGE in ${IMAGES}; do | ||
| echo "Verifying Image ${IMAGE}" | ||
| gcloud auth configure-docker $(awk -F '/' {'print $1'} <<< ${IMAGE} ) --quiet | ||
| docker pull ${IMAGE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think perhaps docker manifest inspect is quicker and less intrusive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never heard of this command, and it seems to be experimental. https://docs.docker.com/reference/cli/docker/manifest/inspect/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Why do you need to fully download with pull and not just verify existence with
curl https://myregistry.com/v2/myapp/tags/list
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alik42 , can you please provide command example for following image: us-central1-docker.pkg.dev/prj-common-442813/lunar-private/mcpx-hub ? Would it be
curl https://us-central1-docker.pkg.dev/prj-common-442813/lunar-private/v2/mcpx-hub/tags/list
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
curl
-H "Authorization: Bearer $(gcloud auth print-access-token)"
"https://us-central1-docker.pkg.dev/v2/prj-common-442813/lunar-private/mcpx-hub/tags/list"
Cannot actually make sure since I dont have credentials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
curl
-H "Authorization: Bearer $(gcloud auth print-access-token)"
"https://us-central1-docker.pkg.dev/v2/prj-common-442813/lunar-private/mcpx-hub/tags/list"
Cannot actually make sure since I dont have credentials.
651a101 to
f1851ec
Compare
This PR implements additional step "Run tests" which is designed to make sure that helm template is render-able and docker images are available in registry