Skip to content

Conversation

@nzolot
Copy link
Contributor

@nzolot nzolot commented Dec 1, 2025

This PR implements additional step "Run tests" which is designed to make sure that helm template is render-able and docker images are available in registry

for IMAGE in ${IMAGES}; do
echo "Verifying Image ${IMAGE}"
gcloud auth configure-docker $(awk -F '/' {'print $1'} <<< ${IMAGE} ) --quiet
docker pull ${IMAGE}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think perhaps docker manifest inspect is quicker and less intrusive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never heard of this command, and it seems to be experimental. https://docs.docker.com/reference/cli/docker/manifest/inspect/

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Why do you need to fully download with pull and not just verify existence with

curl https://myregistry.com/v2/myapp/tags/list

?

Copy link
Contributor Author

@nzolot nzolot Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alik42 , can you please provide command example for following image: us-central1-docker.pkg.dev/prj-common-442813/lunar-private/mcpx-hub ? Would it be

curl https://us-central1-docker.pkg.dev/prj-common-442813/lunar-private/v2/mcpx-hub/tags/list
?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think

curl
-H "Authorization: Bearer $(gcloud auth print-access-token)"
"https://us-central1-docker.pkg.dev/v2/prj-common-442813/lunar-private/mcpx-hub/tags/list"

Cannot actually make sure since I dont have credentials.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think

curl
-H "Authorization: Bearer $(gcloud auth print-access-token)"
"https://us-central1-docker.pkg.dev/v2/prj-common-442813/lunar-private/mcpx-hub/tags/list"

Cannot actually make sure since I dont have credentials.

@nzolot nzolot force-pushed the release-mcpx-webapp-tests branch from 651a101 to f1851ec Compare December 2, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants