-
Notifications
You must be signed in to change notification settings - Fork 181
Submit CodingTracker #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Call911plz
wants to merge
52
commits into
TheCSharpAcademy:main
Choose a base branch
from
Call911plz:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Submit CodingTracker #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the goals to be a checklist managed by Obsidian.
Model (Model.cs), View (UserInterface.cs), Controller (InputController.cs) files added. May rename later.
MakeDB, CreateLog, SelectLog added
CreateDB is only calling MakeDB. Combining to simplify
connection is set in CreateDB (which should be called everytime) and closed in ExitDB (which should be called when user select Exit)
using spectre to make pretty
Will probably make a CreateLog method when making time recording
Makes it return the dataset rather than display it. Some other class will display it
Combined GetStartTime and GetEndTime. Does essentially the same thing.
Getting date and time was essentially the same. Simplified for reusability.
TimeSpan is more easily parsed to string.
Shouldnt be used outside of UserInterface
Made making a session work as well as some UX text, confirmation, etc
May just have a default select method with logic for selecting specific things. However the scope is small enough that this is good for now.
Looks cleaner and easier to handle specific logic.
Sorts by id, start time, end time, duration and if its descending or ascending
Added UserInterface.GetRecordSession which returns a SessionData, MainController.Record calls to insert the data.
Prompts user so should be in UserInterface
Folders are marked to follow the Model, View, Controller, design pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.