big_integer/multiply: improve docs, validation, and clarity#906
Closed
KushalMeghani1644 wants to merge 4 commits intoTheAlgorithms:masterfrom
Closed
big_integer/multiply: improve docs, validation, and clarity#906KushalMeghani1644 wants to merge 4 commits intoTheAlgorithms:masterfrom
KushalMeghani1644 wants to merge 4 commits intoTheAlgorithms:masterfrom
Conversation
Signed-off-by: KushalMeghani1644 <kushalmeghani108@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #906 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 319 319
Lines 20807 20812 +5
=======================================
+ Hits 19834 19839 +5
Misses 973 973 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the multiply implementation in big_integer/multiply.rs:
Added clearer documentation with examples and panic conditions
Replaced char::is_numeric with is_ascii_digit to ensure strict base-10 validation
Improved panic messages for invalid inputs
Simplified multiplication loop for better readability
Renamed some test cases for clarity
Overall, this is a non-breaking change that improves clarity, correctness, and documentation.