dpl: fix PQ_entry to > & == to a total order for determinism #8611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maliberty
approved these changes
Oct 11, 2025
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
openroad-ci
force-pushed
the
dpl-bzl-fixes
branch
from
a168ad5 to
f8fbd08
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
openroad-ci
force-pushed
the
dpl-bzl-fixes
branch
from
f8fbd08 to
44688ac
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Enable bzl test in dpl, cts, some of rsz, test/upf_aes, odb/test/replace_hier_mod1 Signed-off-by: Matt Liberty <[email protected]>
openroad-ci
force-pushed
the
dpl-bzl-fixes
branch
from
44688ac to
e62d9d9
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
|
@maliberty This is where you had to manually tweak test/orfs/gcd/rules.json after run update? |
Member
yes |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Matt Liberty <[email protected]>
openroad-ci
force-pushed
the
dpl-bzl-fixes
branch
from
b30bf7f to
ab5c772
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
|
Master doesn't have this problem #8660 Is this what you see? $ bazelisk run test/orfs/gcd:gcd_update
$ git diff
diff --git a/test/orfs/gcd/rules-base.json b/test/orfs/gcd/rules-base.json
index 6b9d76b18c..56fad9e113 100644
--- a/test/orfs/gcd/rules-base.json
+++ b/test/orfs/gcd/rules-base.json
@@ -56,7 +56,7 @@
"compare": "<="
},
"finish__timing__drv__setup_violation_count": {
- "value": 35,
+ "value": 22,
"compare": "<="
},
"finish__timing__drv__hold_violation_count": {
@@ -67,4 +67,4 @@
"value": -27.94,
"compare": ">="
}
-}
+}
\ No newline at end of file |
Collaborator
|
@maliberty I think ORFS updates rules.json code? #8661 |
Signed-off-by: Matt Liberty <[email protected]>
Signed-off-by: Matt Liberty <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
|
I just had to re-run it after updating and it seemed to work ¯_(ツ)_/¯ |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable all tests bzl