Skip to content

Make print issue variables fix #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2025
Merged

Make print issue variables fix #3291

merged 1 commit into from
Jul 5, 2025

Conversation

@oharboe
Copy link
Collaborator

@oharboe oharboe commented Jul 4, 2025

make print-ISSUE_VARIABLES now works. It failed because it contains newlines.

@oharboe oharboe requested a review from maliberty July 4, 2025 20:43
@maliberty
Copy link
Member

maliberty commented Jul 4, 2025

Please give an example of the problem this is solving.

@oharboe
Copy link
Collaborator Author

oharboe commented Jul 4, 2025

Please give an example of the problem this is solving.

make print-ISSUE_VARIABLES now works, previously it failed with an error

@maliberty maliberty enabled auto-merge July 4, 2025 21:13
@maliberty maliberty merged commit 0b40fdf into The-OpenROAD-Project:master Jul 5, 2025
8 checks passed
@oharboe oharboe deleted the make-print-issue-variables-fix branch July 7, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maliberty maliberty maliberty approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oharboe @maliberty