Skip to content

Conversation

@Modyverbose1
Copy link

[![.Cpython/workflows/assign_pr.yml](https://github.com/Modyverbose1/h4cker/actions/workflows/assign_pr.yml/badge.svg?branch=modyverbose1 patch 1)](https://github.com/Modyverbose1/h4cker/actions/workflows/assign_pr.yml

@santosomar santosomar self-assigned this Nov 12, 2025
Copilot finished reviewing on behalf of santosomar November 12, 2025 15:50
- [explo](https://github.com/telekom-security/explo)
- [Blind SQL Injection via Bitshifting](https://github.com/awnumar/blind-sql-bitshifting)
- [Blisqy](https://github.com/JohnTroony/Blisqy)
- [Blisqy](https://github.com/JohnTroony//Blisqy)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

"description": "This is a Burp Suite extension to help Burp know where to look during scanning."
}
]
{'metadata updated': '2024-06-19T18:30:00Z'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not valid

Iveliz
Ivane
Ita
Issac
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a good addition

with:
github_token: ${{ secrets.GITHUB_TOKEN }}
assignees: 'santosomar'
assignees: 'modyverbose1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not including for the main repo.

@santosomar
Copy link
Contributor

Closing this pull request, as it looks to be a few non-conformant changes for the main repo.

@santosomar santosomar closed this Nov 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR appears to make various modifications across the h4cker cybersecurity resources repository, but most changes introduce errors, incomplete content, or inappropriate modifications rather than valuable improvements.

  • Introduces multiple syntax errors in JSON, YAML, and markdown files
  • Adds incomplete or technically inaccurate documentation to cryptography and IoT sections
  • Inappropriately modifies workflow configurations and author attributions
  • Adds a Python package publishing workflow that doesn't align with the repository's purpose

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 16 comments.

Show a summary per file
File Description
web_application_testing/sql-injection-tools.md Adds line number but introduces double-slash URL error in Blisqy GitHub link
web_application_testing/cookie_stealer_payload.md Adds incomplete "Cookie cloning Payload" section with unclear "kalinet" reference
web_application_testing/burpsuite_plugins.json Appends invalid Python dict syntax after JSON array, breaking JSON format
threat_hunting/find_malicious_ip.py Adds a redundant comment about script functionality
iot_hacking/wireless_iot.md Adds technically inaccurate "Processor" entry with incorrect quantum decryption reference
iot_hacking/flags.md Adds unclear section heading about "server port decryption"
iot_hacking/README.md Adds duplicate heading and incomplete "Software Interfaces" section
crypto/crypto_algorithms.md Adds technically incorrect reference mixing SHA-2 with quantum encryption
crypto/cert_openssl.md Adds vague "quantum certificate" line without context
cracking_passwords/more_wordlists/common_first_names.txt Updates several names in the wordlist
cracking_passwords/cracked2.md Incorrectly changes tool reference and author attribution
cracking_passwords/cracked.md Corrupts code block closing with malformed command prompt text
.github/workflows/python-publish.yml Adds entire PyPI publishing workflow inappropriate for resource repository
.github/workflows/greetings.yml Changes maintainer reference from repository owner to PR author
.github/workflows/assign_pr.yml Modifies PR assignee with syntax error (missing closing quote)

Comment on lines 1067 to +1068
]
{'metadata updated': '2024-06-19T18:30:00Z'}
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line breaks the JSON syntax. JSON arrays cannot have trailing content after the closing bracket. Additionally, Python dictionary syntax ({}) is being mixed with JSON array syntax. If metadata is needed, it should be added as a proper JSON object within the array or in a separate file.

Suggested change
]
{'metadata updated': '2024-06-19T18:30:00Z'}
]

Copilot uses AI. Check for mistakes.
Comment on lines 56 to +57
<img width="1920" alt="image" src="https://github.com/The-Art-of-Hacking/h4cker/assets/1690898/e306aa9c-a980-4001-bc6d-2cbacf7d8b0a">
## Getting the server port decryption and secret Files
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This heading is vague and unclear. It's not evident what "server port decryption" means or what "secret Files" refers to in the context of this document. Either provide more specific context or remove this incomplete section heading.

Suggested change
<img width="1920" alt="image" src="https://github.com/The-Art-of-Hacking/h4cker/assets/1690898/e306aa9c-a980-4001-bc6d-2cbacf7d8b0a">
## Getting the server port decryption and secret Files
<img width="1920" alt="image" src="https://github.com/The-Art-of-Hacking/h4cker/assets/1690898/e306aa9c-a980-4001-bc6d-2cbacf7d8b0a">

Copilot uses AI. Check for mistakes.

- [Identifying JTAG interface](https://blog.senr.io/blog/jtag-explained)
- [NAND Glitching Attack](http://www.brettlischalk.com/posts/nand-glitching-wink-hub-for-root)
# Internet of Things(IoT) Hacking
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after "Things(IoT)". Should be "Things (IoT)" for proper formatting.

Suggested change
# Internet of Things(IoT) Hacking
# Internet of Things (IoT) Hacking

Copilot uses AI. Check for mistakes.
[Contribution Guidelines](CONTRIBUTING.md)
Let me know if you have any questions. Welcome aboard! 🙌 |
Omar Santos @santosomar
modyverbose1@modyverbose1
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change incorrectly modifies the maintainer reference from "santosomar" (Omar Santos, the repository owner) to "modyverbose1". This breaks the intended functionality of the greeting message which should reference the actual repository maintainer.

Suggested change
modyverbose1@modyverbose1
Omar Santos @santosomar

Copilot uses AI. Check for mistakes.
- **DTLS**: Datagram Transport Layer Security, a derivative of TLS designed for datagram protocols.
- **ACLs**: Access Control Lists, which specify which users or system processes are granted access to objects.

** Processor**: Quantum decryption,where primary and secondary access memories are processed.
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after "Processor". Should be "** Processor**:" to properly close the markdown bold formatting.

Suggested change
** Processor**: Quantum decryption,where primary and secondary access memories are processed.
**Processor**: Quantum decryption,where primary and secondary access memories are processed.

Copilot uses AI. Check for mistakes.
Session completed
root@kali:~#
```
rootspynger:~[#380](https://github.com/The-Art-of-Hacking/h4cker/issues/380)
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line appears to be corrupted or malformed. It seems to mix a command prompt with a GitHub issue reference in an inconsistent manner. The original closing triple backticks should be preserved to properly close the code block.

Copilot uses AI. Check for mistakes.
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
assignees: 'santosomar'
assignees: 'modyverbose1
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing quote for the assignees value. The string 'modyverbose1 is not properly closed, which will cause a YAML syntax error. Should be 'modyverbose1'.

Suggested change
assignees: 'modyverbose1
assignees: 'modyverbose1'

Copilot uses AI. Check for mistakes.
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
assignees: 'santosomar'
assignees: 'modyverbose1
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change modifies the PR assignee from the repository owner "santosomar" to "modyverbose1". This breaks the intended workflow configuration and should not be changed unless authorized by the repository owner.

Suggested change
assignees: 'modyverbose1
assignees: 'santosomar'

Copilot uses AI. Check for mistakes.
Comment on lines +7 to +8
# Cookie cloning Payload
kalinet
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition appears incomplete and unclear. "kalinet" without context doesn't provide meaningful information about cookie cloning payloads. Either provide a complete payload example with proper documentation, or remove this line.

Suggested change
# Cookie cloning Payload
kalinet
# Cookie Cloning Payload
<!-- TODO: Add a complete cookie cloning payload example with documentation. -->

Copilot uses AI. Check for mistakes.
Comment on lines +1 to +70
# This workflow will upload a Python Package to PyPI when a release is created
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python#publishing-to-package-registries

# This workflow uses actions that are not certified by GitHub.
# They are provided by a third-party and are governed by
# separate terms of service, privacy policy, and support
# documentation.

name: Upload Python Package

on:
release:
types: [published]

permissions:
contents: read

jobs:
release-build:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

- uses: actions/setup-python@v5
with:
python-version: "3.x"

- name: Build release distributions
run: |
# NOTE: put your own distribution build steps here.
python -m pip install build
python -m build
- name: Upload distributions
uses: actions/upload-artifact@v4
with:
name: release-dists
path: dist/

pypi-publish:
runs-on: ubuntu-latest
needs:
- release-build
permissions:
# IMPORTANT: this permission is mandatory for trusted publishing
id-token: write

# Dedicated environments with protections for publishing are strongly recommended.
# For more information, see: https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment#deployment-protection-rules
environment:
name: pypi
# OPTIONAL: uncomment and update to include your PyPI project URL in the deployment status:
# url: https://pypi.org/p/YOURPROJECT
#
# ALTERNATIVE: if your GitHub Release name is the PyPI project version string
# ALTERNATIVE: exactly, uncomment the following line instead:
# url: https://pypi.org/project/YOURPROJECT/${{ github.event.release.name }}

steps:
- name: Retrieve release distributions
uses: actions/download-artifact@v4
with:
name: release-dists
path: dist/

- name: Publish release distributions to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
packages-dir: dist/
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .github/workflows/python-publish.yml workflow is not appropriate for this repository. This repository is a collection of cybersecurity educational resources and scripts, not a Python package that should be published to PyPI. This workflow should be removed as it doesn't align with the repository's purpose.

Suggested change
# This workflow will upload a Python Package to PyPI when a release is created
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python#publishing-to-package-registries
# This workflow uses actions that are not certified by GitHub.
# They are provided by a third-party and are governed by
# separate terms of service, privacy policy, and support
# documentation.
name: Upload Python Package
on:
release:
types: [published]
permissions:
contents: read
jobs:
release-build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: "3.x"
- name: Build release distributions
run: |
# NOTE: put your own distribution build steps here.
python -m pip install build
python -m build
- name: Upload distributions
uses: actions/upload-artifact@v4
with:
name: release-dists
path: dist/
pypi-publish:
runs-on: ubuntu-latest
needs:
- release-build
permissions:
# IMPORTANT: this permission is mandatory for trusted publishing
id-token: write
# Dedicated environments with protections for publishing are strongly recommended.
# For more information, see: https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment#deployment-protection-rules
environment:
name: pypi
# OPTIONAL: uncomment and update to include your PyPI project URL in the deployment status:
# url: https://pypi.org/p/YOURPROJECT
#
# ALTERNATIVE: if your GitHub Release name is the PyPI project version string
# ALTERNATIVE: exactly, uncomment the following line instead:
# url: https://pypi.org/project/YOURPROJECT/${{ github.event.release.name }}
steps:
- name: Retrieve release distributions
uses: actions/download-artifact@v4
with:
name: release-dists
path: dist/
- name: Publish release distributions to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
packages-dir: dist/

Copilot uses AI. Check for mistakes.
@POXI-q12
Copy link

POXI-q12 commented Nov 12, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants