Refactor Build System to Build Nix and Standard GNU Builds Independantly. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixed the incompatible binary problems by having 2 different actions: 1 to build the nix package as according to the flake, and another to build a generic linux binary which should work on all non-nix POSIX systems. I also made it so that the Nix package would only be build on release, since building the regular package for every push achieves all of the same functionality (testing that the code compiles and dependencies are all present) just much faster.
If building the nix binary every push is desired, then that should be simple to implement since I configured composite actions which are reusable.