Bugfix/overview ifconfig #371
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the last of the incorrect usage of the ifconfig directive. Replace these cumbersome tables with list-tables. This is a little goofy due to old formatting. To keep in line with what was previously here (and to prevent automatic numbering of these tables), we must place the header in the first row and pad accordingly. Signed-off-by: Randolph Sapp <[email protected]>
This was needlessly complicated. Reduce to the only platforms that were affected based on previous logic. Signed-off-by: Randolph Sapp <[email protected]>
StaticRocket
requested review from
cshilwant,
praneethbajjuri,
uditkumarti,
aniket-l and
VeeruPrudhvi
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(overview): reduce ifconfig logic
This was needlessly complicated. Reduce to the only platforms that were
affected based on previous logic.
Signed-off-by: Randolph Sapp [email protected]
fix(overview): remove incorrect ifconfig use
Remove the last of the incorrect usage of the ifconfig directive. Replace
these cumbersome tables with list-tables.
This is a little goofy due to old formatting. To keep in line with what was
previously here (and to prevent automatic numbering of these tables), we must
place the header in the first row and pad accordingly.
Signed-off-by: Randolph Sapp [email protected]