-
Notifications
You must be signed in to change notification settings - Fork 65
docs(linux): AM57X: Sync with 9.3 forked branch #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
14cada5
to
af867b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the rest of these changes are currently acceptable
load = <0x81000000>; | ||
entry = <0x81000000>; | ||
hash-1 { | ||
algo = "sha512"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed indentation breaking code-block here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
||
- Change the CONFIG_DEFAULT_DEVICE_TREE | ||
|
||
For e.g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unusual indentation depth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in v3
.. code-block:: diff | ||
|
||
diff --git a/configs/j721e_evm_a72_defconfig b/configs/j721e_evm_a72_defconfig | ||
index a5c1df7e0054..6d0126d955ef 100644 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed indentation breaking this code-block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in v3
For e.g | ||
|
||
.. code-block:: diff | ||
|
||
diff --git a/arch/arm/dts/k3-j721e-binman.dtsi b/arch/arm/dts/k3-j721e-binman.dtsi | ||
index 673be646b1e3..752fa805fe8d 100644 | ||
--- a/arch/arm/dts/k3-j721e-binman.dtsi | ||
+++ b/arch/arm/dts/k3-j721e-binman.dtsi | ||
@@ -299,8 +299,8 @@ | ||
#define SPL_J721E_SK_DTB "spl/dts/k3-j721e-sk.dtb" | ||
|
||
#define UBOOT_NODTB "u-boot-nodtb.bin" | ||
-#define J721E_EVM_DTB "u-boot.dtb" | ||
-#define J721E_SK_DTB "arch/arm/dts/k3-j721e-sk.dtb" | ||
+#define J721E_EVM_DTB "arch/arm/dts/k3-j721e-common-proc-board.dtb" | ||
+#define J721E_SK_DTB "u-boot.dtb" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like it should be indented to fall under the list item directly above it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in v3
.. note:: | ||
.. ifconfig:: CONFIG_part_variant not in ('AM57X') | ||
|
||
.. note:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unusual indentation depth
|
||
:: | ||
Note for Keystone-2 (K2H/K/E/L/G) platforms: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unusual indentation depth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in v3
└── yocto-build/ | ||
.. code-block:: console | ||
|
||
./ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unusual indentation depth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in v3, Hopefully :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from the indentation cleanup . everything else looks ok for the first sync.
SDK 9.3 had forked document branck for AM57. This commit merge back code section into main branch. Changes in v3: Fixed indentation Changes in v2: 1- Fixed indentation in _Users_Guide.rst 2- _Processor_SDK_Linux_Directory_Structure.rst did clean up as AM57 falls under Jacinto SDK 3- Release_Specific_Release_Notes.rst fixed Addressed review comments Signed-off-by: Udit Kumar <[email protected]>
af867b1
to
f9430d9
Compare
SDK 9.3 had forked document branck for AM57.
This commit merge back code section into main branch.