docs(U-Boot): Refactor K3 and OMAP Build Guide #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaswood01
requested review from
cshilwant,
StaticRocket,
praneethbajjuri,
uditkumarti,
aniket-l and
VeeruPrudhvi
as code owners
github-actions
bot
assigned
bryanbrattlof,
devarsht,
DhruvaG2000,
jeevantelukula,
jmenti,
praneethbajjuri,
r-vignesh and
uditkumarti
|
New issues found with check_toc_txt.py: |
|
New warnings found with rstcheck: |
Mostly cleanup and organization. Some content updated on OMAP. Turns large build guide into its own section under U-Boot, with 6 pages under the build guide. Give feedback if content needs more updating, and I will address in future PR. Signed-off-by: Jonas Wood <[email protected]>
|
New issues found with check_toc_txt.py: |
|
New warnings found with rstcheck: |
cshilwant
requested changes
Jul 8, 2025
sadik-smd
reviewed
Jul 9, 2025
StaticRocket
requested changes
Jul 16, 2025
| Target Images | ||
| ************* | ||
|
|
||
| .. rubric:: Target Images |
There was a problem hiding this comment.
Why the rubric after the section header?
Comment on lines
+34
to
+36
| ^^^^^^^^^^^^^^^^^^^^^^^ | ||
| Getting the Source Code | ||
| ^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Comment on lines
+7
to
+9
| ^^^^^^^^^^^^^^^^^^ | ||
| U-Boot Environment | ||
| ^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
| | K2G ICE | ``k2g_evm_defconfig`` | | | | | | | | | ||
| +----------------------------+-----------------------------+--------------------------+----------------------------------------------+--------------------------+--------------------------+--------------------------+-----------------------------------------+------------------------------------------+ | ||
| | OMAP-L138 LCDK | ``omapl138_lcdk_defconfig`` | | ``omapl138_lcdk_defconfig`` | | | | | | | ||
| +----------------------------+-----------------------------+--------------------------+----------------------------------------------+--------------------------+--------------------------+--------------------------+-----------------------------------------+------------------------------------------+ |
There was a problem hiding this comment.
This would be much easier to review as a list-table
https://docutils.sourceforge.io/docs/ref/rst/directives.html#list-table
|
|
||
| .. ifconfig:: CONFIG_part_variant in ('AM335X') | ||
|
|
||
| If you used 'O=am335x\_evm' as your object directory: |
There was a problem hiding this comment.
This is also applicable to other parameters listed here
Suggested change
| If you used 'O=am335x\_evm' as your object directory: | |
| If you used ``O=am335x_evm`` as your object directory: |
|
|
||
| UG-General-Info |
There was a problem hiding this comment.
You removed UG-General-Info, but left unreachable references in:
configs/AM69/AM69_linux_toc.txt
configs/AM68/AM68_linux_toc.txt
configs/J721S2/J721S2_linux_toc.txt
configs/TDA4VM/TDA4VM_linux_toc.txt
configs/AM67/AM67_linux_toc.txt
configs/J7200/J7200_linux_toc.txt
configs/GEN/GEN_linux_toc.txt
configs/J742S2/J742S2_linux_toc.txt
configs/AM68A/AM68A_linux_toc.txt
configs/DRA821A/DRA821A_linux_toc.txt
configs/AM67A/AM67A_linux_toc.txt
configs/AM69A/AM69A_linux_toc.txt
configs/J784S4/J784S4_linux_toc.txt
configs/J722S/J722S_linux_toc.txt
configs/J721E/J721E_linux_toc.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly cleanup and organization. Some content updated on OMAP. Turns large build guide into its own section under U-Boot, with 6 pages under the build guide. Give feedback if content needs more updating, and I will address in future PR.