feat: cross-platform signal resilience, shell guardrails, and Windows test compatibility#1
Open
PavanKS17 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing the tesslate-agent orchestration for local sandboxing, I implemented a few system-level reliability and security upgrades:
Graceful Container Shutdowns (runner.py): Added explicit SIGINT and SIGTERM handlers. In POSIX environments (Docker/K8s), this ensures trajectories are saved if the container is stopped. On Windows, it gracefully falls back to the standard KeyboardInterrupt block.
Pre-Execution Shell Guardrails (execute.py): Implemented a deterministic regex check to intercept highly destructive commands (e.g., rm -rf /, fork bombs) before they hit the PTY session.
Windows CI Compatibility: Noticed that memory_tool.py imports fcntl at the module level, which crashes the test suite on Windows. I mocked fcntl in the test suite to ensure cross-platform CI tests pass, though we may want to look into portalocker for cross-platform memory file locking in the future.
Added unit tests for both the signal resilience and the shell guardrails to ensure they don't regress.