Skip to content

fix: components props transmit bugs #6157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 18 commits into
base: develop
Choose a base branch
from
Draft

fix: components props transmit bugs #6157

wants to merge 18 commits into from

Conversation

@Wesley-0808
Copy link
Collaborator

@Wesley-0808 Wesley-0808 commented Nov 17, 2025 •
edited by uyarn
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • 本条 PR 不需要纳入 Changelog

tdesign-vue-next

  • fix(AutoComplete): 优化透传组件 props 事件的处理方式，修复透传的回调函数无法触发的问题
  • fix(Cascader): 优化透传组件 props 事件的处理方式，修复透传的回调函数无法触发的问题
  • fix(ColorPicker): 优化透传组件 props 事件的处理方式，修复透传的回调函数无法触发的问题
  • fix(DatePicker): 优化透传组件 props 事件的处理方式，修复透传的回调函数无法触发的问题
  • fix(InputNumber): 优化透传组件 props 事件的处理方式，修复透传的回调函数无法触发的问题
  • fix(RangeInput): 优化透传组件 props 事件的处理方式，修复透传的回调函数无法触发的问题
  • fix(Select): 优化透传组件 props 事件的处理方式，修复透传的回调函数无法触发的问题
  • fix(SelectInput): 优化透传组件 props 事件的处理方式，修复透传的回调函数无法触发的问题
  • fix(TagInput): 优化透传组件 props 事件的处理方式，修复透传的回调函数无法触发的问题
  • fix(Table): 优化透传组件 props 事件的处理方式，修复透传的回调函数无法触发的问题
  • fix(TimePicker): 优化透传组件 props 事件的处理方式，修复透传的回调函数无法触发的问题
  • fix(Transfer): 优化透传组件 props 事件的处理方式，修复透传的回调函数无法触发的问题
  • fix(TreeSelect): 优化透传组件 props 事件的处理方式，修复透传的回调函数无法触发的问题
  • fix(Upload): 优化透传组件 props 事件的处理方式，修复透传的回调函数无法触发的问题

@tdesign-vue-next/chat

@tdesign-vue-next/auto-import-resolver

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@Wesley-0808 Wesley-0808 marked this pull request as draft November 17, 2025 03:02
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 17, 2025

tdesign-vue-next-demo

npm i https://pkg.pr.new/Tencent/tdesign-vue-next/@tdesign-vue-next/auto-import-resolver@6157

npm i https://pkg.pr.new/Tencent/tdesign-vue-next@6157

npm i https://pkg.pr.new/Tencent/tdesign-vue-next/@tdesign-vue-next/chat@6157

commit: dec3b9c

Wesley-0808
Wesley-0808 commented Nov 17, 2025
View reviewed changes
packages/components/select/select.tsx
return () => {
const { overlayClassName, ...restPopupProps } = (props.popupProps || {}) as TdSelectProps['popupProps'];
const inputEvents = useEventForward(props.inputProps, {
onKeydown: (val, { e }) => {
Copy link
Collaborator Author

@Wesley-0808 Wesley-0808 Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处将onkeydown改成了onKeydown，导致处理为props传入，后续组件在调用keydown事件时，屏蔽了enter (见此处)

处理一：
此处不变，input的处理去掉else (不太清楚当时这么处理的原因)：
image
处理二：
此处改回去onkeydown

packages/components/select/select.tsx
size: props.size,
autofocus: props.autofocus,
...(props.inputProps as TdSelectProps['inputProps']),
onkeydown: handleKeyDown,
Copy link
Collaborator Author

@Wesley-0808 Wesley-0808 Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

@tdesign-bot
Copy link
Collaborator

tdesign-bot commented Nov 17, 2025

TDesign Component Site Preview Open

Component Preview
tdesign-vue-next 完成
@tdesign-vue-next/chat 完成

@uyarn uyarn removed the WIP label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PengYYYYY PengYYYYY Awaiting requested review from PengYYYYY PengYYYYY is a code owner

@chaishi chaishi Awaiting requested review from chaishi chaishi is a code owner

@uyarn uyarn Awaiting requested review from uyarn uyarn is a code owner

@zhangpaopao0609 zhangpaopao0609 Awaiting requested review from zhangpaopao0609 zhangpaopao0609 is a code owner

@liweijie0812 liweijie0812 Awaiting requested review from liweijie0812 liweijie0812 is a code owner

@Cat1007 Cat1007 Awaiting requested review from Cat1007 Cat1007 is a code owner

@zydemail zydemail Awaiting requested review from zydemail zydemail is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Wesley-0808 @tdesign-bot @uyarn