Skip to content

Conversation

@nihui
Copy link
Member

@nihui nihui commented Nov 21, 2025

No description provided.

@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot finished reviewing on behalf of nihui November 21, 2025 07:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for an additional RMSNorm pattern variant and improves variable naming for better code organization.

  • Adds a new fusion pass (fuse_rmsnorm_pass_2) to match an alternative algebraic form of RMSNorm computation
  • Renames variables in the fuse_rmsnorm function to use semantic prefixes (a for passes with gamma/weight parameters, g for passes without gamma)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nihui nihui merged commit 14d9715 into Tencent:master Nov 21, 2025
31 of 32 checks passed
@github-actions
Copy link

The binary size change of libncnn.so (bytes)

architecture base size pr size difference
x86_64 15244144 15244144 0 😘
armhf 6225824 6225824 0 😘
aarch64 9526976 9526976 0 😘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants