Skip to content

Conversation

@Miles629
Copy link

This commit removes the line:
sample_stride *= max(1, int(vr.get_avg_fps() / 24)) Rationale:

  • This adjustment overrides the user-specified sample_stride in config
  • When sample_stride is set to 1, this adjustment can cause program failures
  • Example failure case: With num_frames=64 and stride=1, adjustment doubles stride to 2
  • This halves the processed frames from 64 to 32, causing DWPose to only process half the frames
  • Subsequently causes empty indices list generation since tile_size=64 > num_frames=33
  • Empty indices occur in: [[0, *range(i + 1, min(i + tile_size, num_frames))] for i in range(0, num_frames - tile_size + 1, tile_size - tile_overlap)] This change preserves user config settings and prevents downstream processing errors.

This commit removes the line:
sample_stride *= max(1, int(vr.get_avg_fps() / 24))
Rationale:
- This adjustment overrides the user-specified sample_stride in config
- When sample_stride is set to 1, this adjustment can cause program failures
- Example failure case: With num_frames=64 and stride=1, adjustment doubles stride to 2
- This halves the processed frames from 64 to 32, causing DWPose to only process half the frames
- Subsequently causes empty indices list generation since tile_size=64 > num_frames=33
- Empty indices occur in: [[0, *range(i + 1, min(i + tile_size, num_frames))] for i in range(0, num_frames - tile_size + 1, tile_size - tile_overlap)]
This change preserves user config settings and prevents downstream processing errors.
@Miles629
Copy link
Author

image
Here is the Traceback info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant