Skip to content

Conversation

@situ2001
Copy link
Contributor

There is the case that when attribute is changed from style={{ anyKey: foo }} to style={undefined}, JS-side will decide not to inform Native-side for update. For further information, see #4412

Before

Screen_Recording_20250912_203942_Hippy.mp4

After

Screen_Recording_20250912_204025_Hippy.mp4

@github-actions github-actions bot added driver: js size: xs Denotes a PR that changes 0-9 lines labels Sep 12, 2025
@hippy-service
Copy link

hippy-service bot commented Sep 12, 2025

Hi, @situ2001. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Sep 12, 2025

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@zealotchen0 zealotchen0 added the action(squash-merge) Squash and merge action label Sep 24, 2025
@hippy-actions hippy-actions bot enabled auto-merge (squash) September 24, 2025 04:19
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Sep 24, 2025
@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ situ2001
❌ open-hippy
You have signed the CLA already but the status is still pending? Let us recheck it.

situ2001 added a commit to situ2001/Hippy that referenced this pull request Sep 24, 2025
@zealotchen0 zealotchen0 merged commit 1346a15 into Tencent:main Sep 24, 2025
16 of 20 checks passed
@situ2001 situ2001 deleted the situ/style-shouldbe-updated-when-become-nullish branch September 24, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

driver: js size: xs Denotes a PR that changes 0-9 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants