feat(expressions): Add function remoteAddrInList to CEL expressions. #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for this! I'm going to take a look tomorrow once I wake up. |
thess
force-pushed
the
cel-remoteAddrInList
branch
from
54137ac to
20b187b
Compare
thess
force-pushed
the
cel-remoteAddrInList
branch
from
4324cd0 to
93690c5
Compare
thess
force-pushed
the
cel-remoteAddrInList
branch
2 times, most recently
from
3c4c9f8 to
a4a8e87
Compare
3 tasks
thess
force-pushed
the
cel-remoteAddrInList
branch
3 times, most recently
from
73faa5b to
d417eae
Compare
|
Updated to current trunk (again) |
feat(expressions): implement CIDR ranger caching for remoteAddrInList function
Allows bot policy rule to check if remote client address falls within a list of CIDR ranges
For example:
- name: deny-unwanted-scrapers
action: DENY
expression:
all:
- userAgent.matches("(?i)Wget|lftp")
- remoteAddrInList(remoteAddress, [
"5.107.206.0/24",
"2603:c022:8002:6200::8888/128" ])
Signed-off-by: Ted Hess <[email protected]>
Co-authored-by: Jason Cameron <[email protected]>
thess
force-pushed
the
cel-remoteAddrInList
branch
from
d417eae to
a67ea49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows bot policy rule to check if remote client address falls within a list of CIDR ranges
For example:
FWIW - this is my attempt to address #569. I'm not a Golang programmer but was willing to give it a try (hey - code is code) to see if I could resolve my own issue. This function does seem to work OK - I have tested it live but would like to figure out an integration test.
Playwright_testlooks like a place to start. Probably needs re-factoring too.Checklist:
[Unreleased]section of docs/docs/CHANGELOG.mdnpm run test:integration(unsupported on Windows, please use WSL)