Skip to content

Conversation

@tahminehrivandi
Copy link
Collaborator

Please Check My code

@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for simple-shop-technullogy ready!

Name Link
🔨 Latest commit acfa9b4
🔍 Latest deploy log https://app.netlify.com/sites/simple-shop-technullogy/deploys/64947a4cd209e70008cfeeba
😎 Deploy Preview https://deploy-preview-21--simple-shop-technullogy.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@AmirHosseinKarimi
Copy link
Member

Elements should not be larger than their parents.
Also they should have dynamic size. Remove fixed width & height and use font-size, line-height, padding and etc.

screenshot

Browser metadata
Path:      /src/pages/profile.html
Browser:   Firefox 116.0 on Linux x86_64
Viewport:  2560 x 1283 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@AmirHosseinKarimi
Copy link
Member

The whole element should not used as image. The shadow and white background should implemented by CSS and only heart can be image.

screenshot

Browser metadata
Path:      /src/pages/profile.html
Browser:   Firefox 116.0 on Linux x86_64
Viewport:  2560 x 775 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@AmirHosseinKarimi
Copy link
Member

Use flex. Set padding-y to parent to give space from top and bottom instead of setting margin to child element.

Prevent using ABSOLUTE.
Unless there is no way to implement the design.

screenshot

Browser metadata
Path:      /src/pages/profile.html
Browser:   Firefox 116.0 on Linux x86_64
Viewport:  2560 x 775 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@AmirHosseinKarimi
Copy link
Member

Products should be linked to their page.

screenshot

Browser metadata
Path:      /src/pages/profile.html
Browser:   Firefox 116.0 on Linux x86_64
Viewport:  2560 x 775 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@AmirHosseinKarimi
Copy link
Member

Images should be linked to their page.

screenshot

Browser metadata
Path:      /src/pages/profile.html
Browser:   Firefox 116.0 on Linux x86_64
Viewport:  2560 x 775 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@@ -0,0 +1,158 @@
<!DOCTYPE html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply all comments from #20

@AmirHosseinKarimi
Copy link
Member

Use GIT in a proper way. Read the related document about Git that I shared in the group.

@AmirHosseinKarimi
Copy link
Member

Add new pages link as a card to the index page. Like the example that I provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants