🏗️ Consolidate agents into core ai-coding-config plugin #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge the standalone agents plugin into the core ai-coding-config plugin, moving all agents from plugins/agents/agents/ to plugins/core/agents/. This eliminates the redundant plugin naming pattern (agents:mobile-ux-reviewer becomes ai-coding-config:mobile-ux-reviewer) and follows the established pattern used by Claude Code marketplace superpowers and similar plugins. This single-plugin architecture simplifies the marketplace structure while keeping commands, agents, and context in one cohesive package. Users who installed the agents plugin separately will need to reinstall from the main ai-coding-config plugin. Version bumped to 4.0.0 to reflect the breaking change. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Code Review - PR #14: Consolidate agents into core pluginOverviewThis PR successfully consolidates the standalone agents plugin into the core ai-coding-config plugin, improving the user experience by simplifying the plugin structure and fixing the awkward naming pattern. ✅ Strengths1. Clean Architectural Improvement
2. Thorough Documentation Updates
3. Proper File Operations
4. Breaking Change Communication
🔍 Observations & Suggestions1. Migration Path for Existing Users
2. Symlink Compatibility Check - .claude/agents/ → ~/.ai_coding_config/plugins/agents/agents/This is updated correctly in the PR to: - .claude/agents/ → ~/.ai_coding_config/plugins/core/agents/✅ Verified correct 3. Bootstrap Script Compatibility 4. Version Consistency
🔒 Security & Quality
📊 Impact AssessmentPositive:
Neutral:
Risks:
✅ Recommendation: APPROVE with minor suggestionsThis is a well-executed structural improvement. The code quality is excellent, documentation is thorough, and the breaking change is appropriately communicated. Before merge, please verify:
After merge:
Great work on improving the plugin architecture! 🎉 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
TechNickAI
pushed a commit
that referenced
this pull request
Dec 19, 2025
Merge standalone skills plugin into core ai-coding-config plugin following the same pattern as PR #14 for agents. - Move skills from plugins/skills/skills/ to plugins/core/skills/ - Bump marketplace and core plugin version to 5.0.0 - Update all documentation and symlinks - Remove plugins/skills/ directory Previous structure had awkward naming: skills:brainstorming New access pattern: ai-coding-config:brainstorming This completes the consolidation work, creating one unified plugin containing commands, agents, skills, and context. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
4 tasks
TechNickAI
added a commit
that referenced
this pull request
Dec 19, 2025
* 🏗️ Consolidate skills into ai-coding-config plugin Merge standalone skills plugin into core ai-coding-config plugin following the same pattern as PR #14 for agents. - Move skills from plugins/skills/skills/ to plugins/core/skills/ - Bump marketplace and core plugin version to 5.0.0 - Update all documentation and symlinks - Remove plugins/skills/ directory Previous structure had awkward naming: skills:brainstorming New access pattern: ai-coding-config:brainstorming This completes the consolidation work, creating one unified plugin containing commands, agents, skills, and context. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]> * 🐛 Fix duplicate detection paths for consolidated plugin structure Update example paths in ai-coding-config.md to reflect that agents and skills now live in `ai-coding-config/core/*/` instead of separate plugin directories. Cursor Bugbot correctly identified this would cause duplicate detection to fail for skills since the path pointed to non-existent location. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]> * 🐛 Add deleted plugin paths to symlink compatibility check Include deleted skills and agents plugin paths in the list of paths that should trigger symlink updates. Without this, users with direct symlinks to old locations won't be offered the fix. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]> --------- Co-authored-by: Nick Sullivan <[email protected]> Co-authored-by: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
plugins/agents/agents/toplugins/core/agents/Why
The previous structure created redundant naming when accessing agents:
agents:mobile-ux-reviewerhad an awkwardagent-agents:display pattern in Claude Code's @ mentions.Following the pattern used by superpowers and other Claude Code marketplaces, this consolidates everything into a single
ai-coding-configplugin containing commands, agents, and context.New access pattern:
ai-coding-config:mobile-ux-reviewerBreaking Changes
Users who installed the
agentsplugin separately need to reinstall fromai-coding-config:Test plan
@ai-coding-config:mobile-ux-reviewerpattern.claude/agents→plugins/core/agents/ai-coding-configcommand for new installations🤖 Generated with Claude Code