Fix bugs, PSR format, fix PHPDoc.

Controller/AS2Controller.php

@@ -4,14 +4,16 @@
 
 
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Bundle\FrameworkBundle\Controller\Controller;
+use Symfony\Component\HttpFoundation\Response;
 use TechData\AS2SecureBundle\Services\AS2;
 
 /**
  * Description of AS2Controller
  *
  * @author wpigott
  */
-class AS2Controller
+class AS2Controller extends Controller
 {
 
     /**
@@ -27,6 +29,12 @@ function __construct(AS2 $as2Service)
 
     public function inboundAction(Request $request)
     {
-        $this->as2Service->handleRequest($request);
+        try {
+            $this->as2Service->handleRequest($request);
+            return new Response('',200);
+        }
+        catch (\Exception $exception ) {
+            return new Response('',500);
+        }
     }
 }

DependencyInjection/CompilerPass/PartnerProviderCompilerPass.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Created by PhpStorm.
  * User: westin
@@ -13,14 +14,23 @@
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 
 
+/**
+ * Class PartnerProviderCompilerPass
+ *
+ * @package TechData\AS2SecureBundle\DependencyInjection\CompilerPass
+ */
 class PartnerProviderCompilerPass implements CompilerPassInterface
 {
+    /**
+     * @param ContainerBuilder $container
+     */
     public function process(ContainerBuilder $container)
     {
-        // Get the reference for the service
-        $reference = new Reference($container->getParameter('tech_data_as2_secure.partner_provider.service_id'));
-
-        // Add to the partner factory
-        $container->getDefinition('tech_data_as2_secure.factory.partner')->setArguments(array($reference));
+        $partnerProviderResolver = $container->getDefinition('tech_data_as2_secure.partner_provider.resolver');
+        foreach ($container->findTaggedServiceIds('tech_data_as2_partner') as $serviceId => $tags) {
+            $partnerProviderResolver->addMethodCall(
+                'add', [new Reference($serviceId)]
+            );
+        }
     }
-}
+}

DependencyInjection/Configuration.php

@@ -8,7 +8,8 @@
 /**
  * This is the class that validates and merges configuration from your app/config files
  *
- * To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/extension.html#cookbook-bundles-extension-config-class}
+ * To learn more see
+ * {@link http://symfony.com/doc/current/cookbook/bundles/extension.html#cookbook-bundles-extension-config-class}
  */
 class Configuration implements ConfigurationInterface
 {
@@ -18,12 +19,12 @@ class Configuration implements ConfigurationInterface
     public function getConfigTreeBuilder()
     {
         $treeBuilder = new TreeBuilder();
-        $rootNode = $treeBuilder->root('tech_data_as2_secure');
-
+        $rootNode    = $treeBuilder->root('tech_data_as2_secure');
+        
         // Here you should define the parameters that are allowed to
         // configure your bundle. See the documentation linked above for
         // more information on that topic.
-
+        
         return $treeBuilder;
     }
 }

DependencyInjection/TechDataAS2SecureExtension.php

@@ -20,9 +20,9 @@ class TechDataAS2SecureExtension extends Extension
     public function load(array $configs, ContainerBuilder $container)
     {
         $configuration = new Configuration();
-        $config = $this->processConfiguration($configuration, $configs);
-
-        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $config        = $this->processConfiguration($configuration, $configs);
+        
+        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.xml');
     }
 }

Events/Error.php

@@ -11,5 +11,5 @@
  */
 class Error extends Event
 {
-    const EVENT = 'ERROR';
+    const EVENT = 'as2.error';
 }

Events/Log.php

@@ -11,47 +11,77 @@
  */
 class Log extends Event
 {
-
-    const EVENT = 'LOG';
+
+    /**
+     *
+     */
+    const EVENT = 'as2.log';
+    /**
+     *
+     */
     const TYPE_INFO = 'INFO';
+    /**
+     *
+     */
     const TYPE_WARN = 'WARN';
+    /**
+     *
+     */
     const TYPE_ERROR = 'ERROR';
-
+
+    /**
+     * @var
+     */
     private $message;
+    /**
+     * @var
+     */
     private $type;
-
+
+    /**
+     * Log constructor.
+     *
+     * @param $type
+     * @param $message
+     */
     function __construct($type, $message)
     {
-        $this->type = $type;
+        $this->type    = $type;
         $this->message = $message;
     }
-
-
+
+
+    /**
+     * @return mixed
+     */
     public function getMessage()
     {
         return $this->message;
     }
-
+
+    /**
+     * @param $message
+     */
     public function setMessage($message)
     {
         $this->message = $message;
     }
-
+    
     /**
      * @return mixed
      */
     public function getType()
     {
         return $this->type;
     }
-
+    
     /**
      * @param mixed $type
      */
     public function setType($type)
     {
         $this->type = $type;
     }
-
-
+    
+    
 }