Refactor: 금주의 식단 디자인 수정 #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiwoo-jo
added
🎨 DESIGN
m6z1
approved these changes
Apr 10, 2025
app/src/main/java/com/dongyang/android/youdongknowme/ui/adapter/CafeteriaAnotherAdapter.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
말씀해주신 뷰 홀더 수정 후 테스트 진행중 주말 출력 부분에 문제가 있어 같이 수정하였습니다!
|
m6z1
requested changes
Apr 14, 2025
Member
m6z1
left a comment
m6z1
left a comment
There was a problem hiding this comment.
주말에 제대로 동작하는 것 확인했습니다!
코드 놓쳤던 부분 작성해뒀으니 반영 부탁드려요!
고생하셨습니다 ㅎㅎ 👍
app/src/main/java/com/dongyang/android/youdongknowme/ui/view/cafeteria/CafeteriaFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/dongyang/android/youdongknowme/ui/view/cafeteria/CafeteriaFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/dongyang/android/youdongknowme/ui/view/cafeteria/CafeteriaFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/dongyang/android/youdongknowme/ui/view/cafeteria/CafeteriaViewModel.kt
Outdated
Show resolved
Hide resolved
|
|
||
| private val _daysMenus: MutableLiveData<List<String>> = MutableLiveData() | ||
| val daysMenus: LiveData<List<String>> = _daysMenus | ||
| private val _anotherMenus: MutableLiveData<List<Array<String>>> = MutableLiveData() |
Member
There was a problem hiding this comment.
anotherMenus 로 변경하게 된 계기가 있나욥 ??
다른 메뉴보다 daysMenus 가 더 명시적인 것 같아서요!
Contributor
Author
There was a problem hiding this comment.
일품 메뉴 안에는 고정적으로 매일 판매하는 메뉴와 날마다 변동되는 메뉴들이 있습니다!
저는 daysMenus는 일품 전체보다는 각 요일에 한정적으로 판매하는 메뉴가 더 생각나서 anotherMenus로 변경하였습니다
app/src/main/java/com/dongyang/android/youdongknowme/ui/view/cafeteria/CafeteriaViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/dongyang/android/youdongknowme/ui/view/cafeteria/CafeteriaViewModel.kt
Outdated
Show resolved
Hide resolved
m6z1
approved these changes
Apr 19, 2025
Member
m6z1
left a comment
m6z1
left a comment
There was a problem hiding this comment.
코멘트 반영만 부탁드려요!
고생하셨습니다 : )
반영 후 머지 고고싱
app/src/main/java/com/dongyang/android/youdongknowme/data/model/AnotherMenuItem.kt
Outdated
Show resolved
Hide resolved
|
|
||
| private fun setupCalendar() { | ||
| val wmc = WindowMetricsCalculator.getOrCreate().computeCurrentWindowMetrics(requireActivity()) | ||
| val dayWidth = wmc.bounds.width() / 5 |
huiwoo-jo
commented
Apr 21, 2025
Comment on lines
+132
to
+134
| TypedValue.COMPLEX_UNIT_DIP, | ||
| DATE_CELL_HEIGHT_DP, | ||
| resources.displayMetrics |
Contributor
Author
There was a problem hiding this comment.
기존에 셀 높이의 124f도 상수화하였습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📮 관련 이슈
✍️ 구현 내용
📷 구현 영상
default.mp4
✔️ 확인 사항