[Fix] Upstash Redis TLS 연결 문제 해결#212
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRedisConfig의 Redis 연결 설정이 비밀번호 주입과 Lettuce 클라이언트의 TLS/SSL 옵션으로 확장되었습니다. 프로덕션 프로필에서 Redis SSL을 활성화하고 API 기본 URL을 설정합니다. ChangesRedis TLS/SSL 지원
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/java/com/proovy/global/config/RedisConfig.java`:
- Around line 32-47: In RedisConfig.redisConnectionFactory currently the
password field is allowed to be empty and the code only sets config.setPassword
when password is non-blank; change this so that when sslEnabled
(spring.data.redis.ssl.enabled) is true and password is null/blank you fail
fast: detect blank password (password == null || password.trim().isEmpty()) and
throw a clear IllegalStateException (or similar) from redisConnectionFactory
indicating TLS is enabled but spring.data.redis.password is missing, otherwise
continue to set config.setPassword(password) as before.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 36699e4f-8b49-468f-9545-abf5fa89b88a
📒 Files selected for processing (2)
src/main/java/com/proovy/global/config/RedisConfig.javasrc/main/resources/application.yaml
💤 Files with no reviewable changes (1)
- src/main/resources/application.yaml
📌 관련 이슈
🏷️ PR 타입
📝 작업 내용
Upstash Redis TLS 연결 실패 문제 해결
prod 환경에서 Upstash Redis 연결 시
Connection closed prematurely at RedisHandshakeHandler오류 발생하던 문제를 해결했습니다.주요 수정사항:
ProtocolVersion.RESP2명시적 설정bundle.implicit: true설정 제거기술적 세부사항:
LettuceClientConfiguration으로 SSL 옵션 명시적 구성ClientOptions에 RESP2 프로토콜 버전 설정SslOptions에 JDK SSL 프로바이더 적용SocketOptions에 연결 타임아웃 및 Keep-alive 설정📸 스크린샷
컴파일 성공 확인:
./gradlew compileJava통과2개 파일 수정: RedisConfig.java, application.yaml
✅ 체크리스트
📎 기타 참고사항
Summary by CodeRabbit
Release Notes