fix: CD path filter misses frontend submodule pointer bumps - #340
Merged
Conversation
'deepiri-web-frontend/**' only matches files inside the dir, not a gitlink change to the submodule path itself -- so bumping the deepiri-web-frontend submodule pointer (as in PR #339) never triggered a redeploy. Add the bare 'deepiri-web-frontend' entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #339 bumped the deepiri-web-frontend submodule pointer to ship a perf fix, but no CD run fired. Cause: the path filter
deepiri-web-frontend/**only matches changes to files inside that directory — a submodule pointer bump is a gitlink change to thedeepiri-web-frontendpath itself, which that glob doesn't match. Adding the baredeepiri-web-frontendentry fixes it for future submodule bumps.