chore(ci): cut Actions minutes (concurrency, PR CI/CodeQL) - #4
Conversation
|
Hey — this took too long, so I did it myself. I asked y'all to get Actions minute hygiene done like ~3 weeks ago. Fine, stuff slips. But damn man — you see my velocity? I have a full-time job, I lead Exovra, and I lead this entire org. In just the last two weeks on Deepiri alone I still shipped, among other things:
And I still found time to complete the org-wide Actions optimization your team was supposed to own — concurrency cancel, stop post-merge CI/CodeQL double-fires, keep CD, keep CodeQL, paths-ignore, timeouts, web-frontend job consolidation. Do not merge until you've actually looked. Review it. Sent Using Claude |
Keep PR CI/CodeQL on main/dev (including subsequent PR pushes), cancel stale runs, drop post-merge push double-fires, add paths-ignore and timeouts. CD deploy triggers left intact. Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
1856752 to
3bcb15f
Compare
nhuynh30
left a comment
There was a problem hiding this comment.
Overall, this looks good. However, I don't think it's ready to merge yet. I found two changes I'd make before merging:
- Don't use cancel-in-progress: true for releases, because cancelling a release while it's publishing could leave the release or Docker image in an incomplete state.
- Don't remove push: dev while keeping the dev → main CI skip, because dev will no longer be tested after merges, so the dev → main PR could reach main without CI running.
| group: release-${{ github.workflow }} | ||
| cancel-in-progress: false | ||
|
|
||
| cancel-in-progress: true |
There was a problem hiding this comment.
I don't think we should enable cancel-in-progress for the release workflow. Since this workflow publishes the release, cancelling an in-progress run could leave a release partially published. I'd keep cancel-in-progress: false here.
| on: | ||
| pull_request: | ||
| branches: [main, dev] | ||
| push: |
There was a problem hiding this comment.
Removing the push: [dev] trigger makes the dev → main skip incorrect. A merge into dev will no longer run CI, but the later dev → main PR is still skipped. We should either keep the push: [dev] trigger or remove the dev → main skip.
Summary
cancel-in-progress, CI/CodeQL stay onpull_request→main/dev(including subsequent pushes to the PR), drop post-mergepushdouble-fires.paths-ignore+ sensibletimeout-minutes.Test plan
main/dev→ CI + CodeQL runpushon no-CD pathDo not merge without review.
Sent Using Claude