Skip to content

Add low lying area map editing#1668

Draft
dltacube wants to merge 5 commits into
Tasshack:devfrom
dltacube:add-low-lying-area-editing
Draft

Add low lying area map editing#1668
dltacube wants to merge 5 commits into
Tasshack:devfrom
dltacube:add-low-lying-area-editing

Conversation

@dltacube

Copy link
Copy Markdown

Summary

  • implement low-lying area editing for saved maps
  • preserve the map payload key used for low-lying areas
  • include saved low-lying area payload fields so creation and deletion persist across map refreshes

Testing

  • python -m py_compile custom_components/dreame_vacuum/dreame/device.py custom_components/dreame_vacuum/dreame/map.py custom_components/dreame_vacuum/dreame/types.py
  • git diff --check origin/dev..HEAD
  • installed fork build in Home Assistant via HACS
  • verified vacuum_set_low_lying_area creation persisted on both camera.todd_map and camera.todd_map_1 after refresh polling
  • verified vacuum_set_low_lying_area deletion with an empty area list persisted on both camera.todd_map and camera.todd_map_1 after refresh polling

@dltacube

Copy link
Copy Markdown
Author

@Tasshack did you have trouble with this feature and keeping the markers to stick?

@Tasshack

Copy link
Copy Markdown
Owner

I haven't reverse engineered this part of the official APP yet, that is why it is not supported. I have no idea how these work yet.

This is probably the part you are having an issue, it needs to return the key instead of area list.

        return {
            low_lying_area_key: areas_payload,
            "sneak_areas": areas_payload,
            "sneak_areas_end": areas_payload,
        }

@Tasshack

Copy link
Copy Markdown
Owner

This is also not correct, check other update_map_data calls.

return self.update_map_data_async(self._map_manager.editor.set_low_lying_areas(areas))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants