Reject passphrase config option without argument - #697
Merged
cperciva merged 1 commit intoJul 10, 2026
Conversation
Contributor
Author
|
Additional validation from this environment:
I still cannot run the full autotools build/test suite locally here because the available WSL environment lacks the needed build tools, but the patch remains a minimal control-flow guard. |
Member
|
Closing and re-opening to trigger CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #696 by making the passphrase configuration-file option follow the same missing-argument path as other argument-requiring options.
When passphrase appears without an argument, dooption() now jumps to the existing
eedarg handler before calling passphrase_entry_parse(), avoiding the NULL dereference reported in the issue.
Validation
I was unable to run a local build in this environment because repeated git clone attempts to GitHub failed with network connection resets/timeouts, so I submitted the minimal patch through the GitHub API.