Skip to content
This repository was archived by the owner on Jun 14, 2023. It is now read-only.

Conversation

@StabbyCutyou
Copy link
Contributor

ping @lumost @wjossey

WIP, not entirely finished, still hacking on it, but this is what I'm envisioning for a 2.0:

Better internal code orgnanization
Re-think of Partitions (http://github.com/StabbyCutyou/partitionring)
More consistent API response valus
Drop martini, logrus, use built in stuff for performance
Consolidate configuration updates into a single goroutine
Abstract all riak-y logic into a DAL-like object (I don't 100% love this, theres room for improvement, but this lets us split apart "Dynamiq" from "Riak" code wise)

Haven't yet deleted any old code, still using it as a reference, but basically everything in app will be removed.

@StabbyCutyou
Copy link
Contributor Author

So, at this point the core feature set (except deletes) works (but since deleting never ACTUALLY deleted...), minus a few things (configuring queues, haven't yet tested unsubscribing queues from topics).

Would love some feedback here, especially on the use of https://github.com/StabbyCutyou/partitionring for partitions. It has one drawback, which is no "skip' function like the old on had, but it does have a lot of core improvments I feel. I'm working on something to get around the skip function issue, by having it internally track where it last was, and start searching from that point forward until it loops back around, which would prevent the current bias of always favoring the "left" side of the partitions (so, prevent it from always starting at 0).

Feedback welcome and sought.

@StabbyCutyou
Copy link
Contributor Author

ping @lumost

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how this is split out

@lumost
Copy link
Contributor

lumost commented Nov 11, 2015

haven't looked at partition ring yet but this is a big leap forward for this code base. thanks @StabbyCutyou

@jplock
Copy link

jplock commented Mar 9, 2016

Any idea when this will be merged?

@StabbyCutyou
Copy link
Contributor Author

Hey @jplock,

So the V2 branch was a bit of a side project while I had spare capacity, but that time has dried up a bit. I am still interested in finishing the branch and merging it, but it needs some more testing and polish work before it's complete.

Specifically, removing the partition management logic that was spilled over a few places in the old code, and using the extracted PartitionRing concept needs more testing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants