feat: Onboarding Pill#2440
Open
camielvs wants to merge 1 commit into
Open
Conversation
🎩 PreviewA preview build has been created at: |
This was referenced Jun 19, 2026
Collaborator
Author
a27cdb0 to
72eadf3
Compare
c38d713 to
5f5d39b
Compare
72eadf3 to
14fbe7b
Compare
5f5d39b to
c994062
Compare
14fbe7b to
a39fbd9
Compare
c994062 to
bbdf96e
Compare
a39fbd9 to
ebc0b79
Compare
bbdf96e to
5ea2aaa
Compare
ebc0b79 to
3b09b65
Compare
7b70ec6 to
601fa2a
Compare
30b5b30 to
5d180fd
Compare
601fa2a to
0da37a4
Compare
5d180fd to
4e68a1c
Compare
4e68a1c to
c818dc8
Compare
0da37a4 to
5a2f860
Compare
camielvs
commented
Jun 19, 2026
camielvs
left a comment
Collaborator
Author
There was a problem hiding this comment.
Pill + readiness gating + toasts look good. The isResolved = (backendReady || !configured) && isReady contract is a clean way to avoid the flash, and the completedRef baseline correctly suppresses toast spam on first load. Two inline notes.
b5d4e02 to
f838ac6
Compare
3cce650 to
8bdff0e
Compare
8bdff0e to
2741cce
Compare
f838ac6 to
0b64d0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Second PR in the onboarding series (stacked on #2421). Makes onboarding progress visible from anywhere in the app, not just the Learning Hub.
OnboardingNavPill— a compactOnboarding · X/Ypill that opens a popover with the full checklist. Mounted in both the v1 and v2 editor navs (hidden in tour mode). It hides itself once onboarding is complete or dismissed.isReady/isResolvedso the pill (and other surfaces) only render once backend state has actually resolved, avoiding a flash of default/incorrect state on load.No new routes or page-level changes — purely an always-available entry point plus the supporting provider state.
Related Issue and Pull requests
Progresses https://github.com/Shopify/oasis-frontend/issues/622
Stacked on #2421 → followed by #2435
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Onboarding · X/Ypill appears in the top nav in both the v1 and v2 editors.Additional Comments
Gating is on
isResolved(backend resolved + state loaded) rather thanisReady, so the pill never renders against unresolved state.