fix(router-core): update ErrorRouteComponent to support generic error type #4727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: leesb971204 <[email protected]>
|
View your CI Pipeline Execution ↗ for commit 690778e
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-plugin
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-plugin
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-server
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
michaelbull
reviewed
Jul 21, 2025
| @@ -49,7 +49,7 @@ import type { LinkComponentRoute } from './link' | |||
| declare module '@tanstack/router-core' { | |||
| export interface UpdatableRouteOptionsExtensions { | |||
| component?: RouteComponent | |||
| errorComponent?: false | null | ErrorRouteComponent | |||
| errorComponent?: false | null | ErrorRouteComponent<any> | |||
There was a problem hiding this comment.
Is there a reason we wouldn't add the TError generic?
export interface UpdatableRouteOptionsExtensions<TError = Error> {
errorComponent?: false | null | ErrorRouteComponent<TError>There was a problem hiding this comment.
Is there a reason we wouldn't add the
TErrorgeneric?export interface UpdatableRouteOptionsExtensions<TError = Error> { errorComponent?: false | null | ErrorRouteComponent<TError>
If we make this change, wouldn’t it cause a type error in the errorComponent?
There was a problem hiding this comment.
Do you have any additional ideas regarding this?
There was a problem hiding this comment.
Not really sure to be honest. Its unclear to me why that would cause a compiler error, and I explicitly use code-based routing (createRoute) not file based. I suspect you would have to chase the generic error type onto UpdatableRouteOptionsExtensions as well, but now I'm starting to second guess following this through.
I would defer to @schiller-manuel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4686
more of #4691
I added a generic to
ErrorComponentPropsto allow specifying the error type,but since the generic wasn’t passed through in the
ErrorRouteComponenttype, I added explicit typing there as well.