Skip to content

feat: add vue-pacer, debounce helper, docs, example #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: add vue-pacer, debounce helper, docs, example #29

wants to merge 15 commits into from

Conversation

MrSunshyne
Copy link

@MrSunshyne MrSunshyne commented May 31, 2025 •
edited
Loading

I closed the original PR because Files Changed seemed abnormal.
I recreated by cherry-picking the relevant commits into this new branch.

This is a vue-adapter for tanstack-pacer and so far only brings one function:

  • useDebouncer, with docs and examples.

After some reviews and, I can work on the rest of the helpers to align with what's available.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5c20722

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MrSunshyne MrSunshyne marked this pull request as ready for review May 31, 2025 15:22
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 31, 2025 •
edited
Loading

More templates

npm i https://pkg.pr.new/TanStack/pacer/@tanstack/pacer@29

npm i https://pkg.pr.new/TanStack/pacer/@tanstack/react-pacer@29

npm i https://pkg.pr.new/TanStack/pacer/@tanstack/solid-pacer@29

npm i https://pkg.pr.new/TanStack/pacer/@tanstack/vue-pacer@29

commit: 9894107

@MrSunshyne
Copy link
Author

@KevinVandy Is there something I can do to unblock the failing CI?

@KevinVandy
Copy link
Member

@KevinVandy Is there something I can do to unblock the failing CI?

Are you running pnpm test before committing and pushing?

@MrSunshyne
Copy link
Author

Thanks for the tip! I wasn't doing that. It helped me find and fix the issue 🙏

@KevinVandy
Copy link
Member

This PR is going in the right direction. It would be nice if the examples tried to mirror the react examples as much as possible so that devs could have apples to apples comparisons. Like having the exact same example structure.

KevinVandy
KevinVandy reviewed Jun 8, 2025
View reviewed changes
packages/vue-pacer/src/debouncer/useDebouncer.ts
/** Set a new value (will be debounced) */
setValue: (newValue: TValue) => void
/** Force immediate update of the value */
flush: () => void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flush is new functionality and should probably just be added to the core package instead of being implemented at the adapter level.

@KevinVandy
Copy link
Member

There's a lot of work ahead of us to get a full vue adapter for TanStack pacer in here, but if only the debouncing gets polished up enough, we can ship it. I like what I see so far and will try to find some time this week to work on this branch too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinVandy KevinVandy KevinVandy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrSunshyne @KevinVandy