fix: resolve type errors and add type checking to CI#17
Merged
Conversation
Add test:types script to the intent package and wire root-level tsc into the test:ci and test:pr pipelines so type errors are caught on every PR. Fixes Dirent<NonSharedBuffer> issues from @types/node v25, narrows regex match groups for noUncheckedIndexedAccess, and excludes eslint.config.js from root type checking due to non-portable inferred types. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test:typesscript to@tanstack/intentpackage so NX can run per-package type checkingtsc --noEmitintotest:ciandtest:prpipelines for root-level type checking (scripts, configs)Changes
packages/intent/src/scanner.ts&library-scanner.ts: FixDirent<NonSharedBuffer>errors from@types/nodev25 by using explicitencoding: 'utf8'withreaddirSync; prefix unused params with_packages/intent/src/utils.ts&scripts/validate-skills.ts: Narrow regexmatch[1]fornoUncheckedIndexedAccesssafetypackages/intent/src/intent-library.ts: Assertprocess.argv[1]!(always defined in script context)packages/intent/package.json: Add"test:types": "tsc --noEmit"package.json: Prefixtest:ciandtest:prwithtsc --noEmit &&for root-level type checkingtsconfig.json: Excludeeslint.config.js(non-portable inferred type from@eslint/core)Test plan
tsc --noEmitpasses at root leveltsc --noEmitpasses inpackages/intenttest:pr) passes on this PR🤖 Generated with Claude Code