-
-
Notifications
You must be signed in to change notification settings - Fork 470
feat: Add new AppField API for Angular #1541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Lars Hanisch <[email protected]>
View your CI Pipeline Execution ↗ for commit f23e383.
☁️ Nx Cloud last updated this comment at |
The dependency injection doesn't guarantee type safety, so now we are able to assign a number field to the To be fair currently we don't have typesafety in the "simple" example, too, when assigning the I wonder if it's possible to create something like the More research is needed... |
This is known, but trivially resolved by adding a:
As a property no the
That... Isn't accurate from my testing when I first wrote the adapter of Angular... I wonder if there's been a regression in Angular on this area. Reproduction and deeper investigation would be welcome |
This PR breaks the abiltiy to run tests thanks to Testing Library seemingly not supporting Angular 20
I made a few steps back to get a better understanding of what's going on. In today's timeslot I removed the extra layers and derived the For now with a complete set of all the types (because I don't know which one can be I guess in other frameworks the "glue" to make this friendlier is the |
You may want to cherry-pick The refactoring to input signals of the Does the (unnecessary) update of the options on the first run of the effect hurt? Or is the "no change actually happened" intercepted somewhere in the underlying store? Otherwise a "needs update because of some change" check could be implemented inside the effect comparing the next values of the options to the current ones of |
I just tried with the |
This PR adds in a new
AppField
API for our Angular adapter, which massively improves the DX of the library.Huge thank you to @flensrocker for the inspiration and pair-coding on this problem!
TODOs