chore(deps): update dependency jsdom to v29#394
Conversation
📝 WalkthroughWalkthroughThe Changesjsdom Dependency Bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit 288553f
☁️ Nx Cloud last updated this comment at |
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pnpm-workspace.yaml (1)
30-30: Note major architectural changes in jsdom 29.x that may require test updates.The CSSOM implementation was overhauled, replacing
@acemir/cssomand cssstyle dependencies with fresh internal implementations. Serialization, parsing, and API behavior is improved in various ways, especially around edge cases. Added cssKeyframeRule.keyText getter/setter validation and cssStyleRule.selectorText setter validation: invalid selectors are now rejected.If the codebase has tests that rely on CSS parsing or DOM selector functionality, they should be validated to ensure they work correctly with the new CSSOM implementation.
Would you like me to search the codebase for tests using jsdom or CSS-related functionality that may need validation after this upgrade?
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pnpm-workspace.yaml` at line 30, The jsdom dependency has been upgraded to version 29.1.1, which includes major CSSOM implementation changes with stricter validation for CSS selectors and keyframe rules. Search the test files throughout the codebase for tests that interact with CSS parsing, DOM selector functionality, cssStyleRule.selectorText manipulation, or cssKeyframeRule.keyText operations, and validate that these tests still pass with the new stricter validation behavior. Any tests that set invalid selectors or keyText values will now be rejected by the new CSSOM implementation and should be updated to use valid CSS syntax or have their expectations adjusted accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@pnpm-workspace.yaml`:
- Line 30: The jsdom dependency has been upgraded to version 29.1.1, which
includes major CSSOM implementation changes with stricter validation for CSS
selectors and keyframe rules. Search the test files throughout the codebase for
tests that interact with CSS parsing, DOM selector functionality,
cssStyleRule.selectorText manipulation, or cssKeyframeRule.keyText operations,
and validate that these tests still pass with the new stricter validation
behavior. Any tests that set invalid selectors or keyText values will now be
rejected by the new CSSOM implementation and should be updated to use valid CSS
syntax or have their expectations adjusted accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0d0d3a47-04f2-4a9f-b6ec-ad961ed1f5eb
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
pnpm-workspace.yaml
1 participant
This PR contains the following updates:
^28.1.0→^29.1.1Release Notes
jsdom/jsdom (jsdom)
v29.1.1Compare Source
'border-radius'computed style serialization. (@asamuzaK)'background-origin'and'background-clip'CSS properties. (@asamuzaK)getComputedStyle(), before the cache warms up. (@asamuzaK)v29.1.0Compare Source
getComputedStyle()sometimes returning outdated results after CSS was modified. (@asamuzaK)v29.0.2Compare Source
getComputedStyle(). Computed value rules are now applied across a broader set of properties, and include fixes related to inheritance, defaulting keywords, custom properties, and color-related values such ascurrentcolorand system colors. (@asamuzaK)'background' and'border'shorthand parsing. (@asamuzaK)v29.0.1Compare Source
'border','background', and their sub-shorthands containing keywords orvar(). (@asamuzaK)getComputedStyle()to return a more functionalCSSStyleDeclarationobject, including indexed access support, which regressed in v29.0.0.v29.0.0Compare Source
Breaking changes:
Other changes:
@acemir/cssomandcssstyledependencies with fresh internal implementations built on webidl2js wrappers and thecss-treeparser. Serialization, parsing, and API behavior is improved in various ways, especially around edge cases.CSSCounterStyleRuleandCSSNamespaceRuleto jsdomWindows.cssMediaRule.matchesandcssSupportsRule.matchesgetters.MediaList, usingcss-treeinstead of naive comma-splitting. Invalid queries become"not all"per spec.cssKeyframeRule.keyTextgetter/setter validation.cssStyleRule.selectorTextsetter validation: invalid selectors are now rejected.styleSheet.ownerNode,styleSheet.href, andstyleSheet.title.Documentinitialization performance by lazily initializing the CSS selector engine, avoiding ~0.5 ms of overhead perDocument. (@thypon)CSSStyleDeclarationmodifications to properly trigger custom element reactions.@mediarule parsing.CSSStyleSheet's "disallow modification" flag not being checked in all mutation methods.XMLHttpRequest'sresponsegetter returning parsed JSON during theLOADINGstate instead ofnull.getComputedStyle()crashing in XHTML documents when stylesheets contained at-rules such as@pageor@font-face.XMLHttpRequestcaused by a race condition with the worker thread's idle timeout.Configuration
📅 Schedule: (UTC)
* 0-3 * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.