-
-
Notifications
You must be signed in to change notification settings - Fork 417
fix: folders with names of unlinked entries are linked #1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like everything that's here fixes the specific areas they target, but there's still a few circumstances left that should be addressed before #989 should be considered closed:
- The relink process still does not check if a file is a folder when relinking
- Various methods in
ThumbRenderer
andPreviewThumb
such as_image_thumb()
will crash the program or throw a traceback if trying to render a thumbnail for a file that's been swapped with a folder of the same name, most notably_image_thumb()
in my testing
I thought there may have been some stuff I missed. 🤔 I'll work on those changes as soon as I can. 👍 |
de574cb
to
ef16ffa
Compare
Sorry for the force push, had to fix conflicts. Anyways, all requested changes should be finished. Let me know if there is anything else I should change 😄 |
Summary
Fixes #989
When a unlinked entry has a folder with the same name:
Let me know if there is any changes you would like me to make :)
Tasks Completed