-
Notifications
You must be signed in to change notification settings - Fork 11
[FEAT] Live render #1055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[FEAT] Live render #1055
Conversation
Other than what we did before we do now a full overwrite of the run command. This allows us to remove a number of less optimal constructions in the command. The change itself is empowered by the changes in phpdocumentor/guides-cli 1.9 which now provides a number of helper classes to simplify self build run commands.
Can I already try this out, if so how? |
Right now you can build the docker image local from this branch. Don't forget to run composer install first. Now you run: When you visit http://localhost:1337/Index.html you should see your documentation. If you edit your index.rst file you should see that the rendering starts again and when finished your browser page reloads. To stop the server again you can press CTRL+c. Right now this branch does not contain any method to disable the behavior to start the dev server. This will be added in a later commit. |
744a455
to
62e78b3
Compare
Just to add to our slack discussion: I now tried this just with "make docker-build" and then your docker run command. This works for me on a basic level. However I for example renamed an anchor inside one file, then the rendering caught that on and spewed out dozens of pages of "dupllicate anchors": I did that with the TYPO3 EXT:form extension: https://gist.github.com/garvinhicking/ee3a65890ad5a8ff85c32d328a82c30b |
When I render EXT:form with the current deployed container it renders fine, with this one I get a couple of errors:
not sure if that is caused by the different dev-process or the other changes in |
This feature will allow documentation writers to have a live reload of there changes.