Conversation
…, preparation functions, add temp directory
…ndable, fix track formatting
…f two for rome cluster constrained jobs
|
@fnattino I requested your review for two specific files (the rest you can ignore if you want):
These two files contain the calls to I have generated results for my testing area of interest, they are located in |
fnattino
left a comment
There was a problem hiding this comment.
Looks good @Simon-van-Diepen ! Nice that this seems to work, I have added just a couple of comments.
And just to confirm, have you added the following lines to your ~/.esa_snap/etc/snap.properties?
znap.compression.level=5
znap.compressor.id=zlib
znap.use.zip.archive=false
This is to have GPT already writing unzipped ZNAP dirs. I see you have a note on this in the PR description, but I could not see any clean up script, so I imagine you already included this.
Related to this, maybe it would be good to point GPT to a common config files, saved somewhere in the /project/caroline/Software ? This way everyone running caroline would use the same settings without having to modify a configuration file in their HOME folder. Let me know what you think, I can look up what exactly needs to be changed in the GPT settings.
|
@fnattino regarding your general comment, I have indeed not added those three lines to my config file. The two main reasons for that are that I want CAROLINE to be able to completely install itself without having to modify settings like that, and that this is a global config file meaning the testing environment and live environment are no longer fully separated (so a test with different settings would also impact the live runs immediately). Hence my workaround with an unzipping script (which is hidden in However, your idea of a CAROLINE SNAP config file is interesting, if this could be broadcast directly to the GPT command, since then multiple versions of that config file can exist concurrently without interfering. Do you know how to do that? |
I see, and indeed it would be nice not to have dependencies on other config files. Unfortunately, GPT does not allow you to specify all config options as CLI arguments (it is not clear to me why).
Well, as far I can see you cannot specify the path to a config file as a GPT CLI argument. What I meant with my comment, is that you could add the Zarr configuration option to the global SNAP config file, i.e. |
|
@fnattino since that'd be a global change I'll check with the group if it will break someone's implementation if there would be unzipped ZNAP files being outputted. If not I'll shoot Niels an email to ask to add this (I have the permissions to do so too but I think it's cleaner to go via him) Thanks for all your feedback! I'm running one more fullscale test now to see if everything is still working as intended, and then I'll merge. |
|
@fnattino after discussion with the group those three lines have been added. Everything works as intended, so I'll merge now. Thanks for your feedback! |
Adds:
snap_preparation job: prepares the run folder and the XML graphs, which are numbered for jobarray execution
snap_run job: an arrayjob where each subjob runs one graph, and outputs a
.znap.ziparchivesnap_cleanup job: unzips all the
.znap.ziparchives into.znap, which are readable using Python'szarrpackage, and removes the.znap.ziparchivessupport for arrayjobs within Caroline (in scheduler, preparation, and email)
snap-coregistration dependency