wip: Expose HDF5 type conversion handling#43
Draft
lukas-weber wants to merge 1 commit into
Draft
Conversation
fdbcacc to
fca9584
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a way to control the currently hard-coded handling of type mismatches between HDF5 files and what is requested on the C++ side,
which will simply print a warning if types are not different.
HDF5 has rich support to customize this behavior via dataset transfer property list and the associated type_conv callback. h5 now maintains a default transfer property list on the library global scope. This transfer property list is passed to every HDF5 read and write call that takes it. Setting a callback is exposed to the user via
h5::set_type_conv_cb.The callback closely mirrors what HDF5 does, up to two additional calling conditions
h5::conv_except::not_equal(types not equal)h5::conv_except::narrower(dst type is narrower), for which HDF5 will just handle silently unless the value being read/written will actually not fit in the destination. h5 calls the callback manually for that reason to reproduce the old behavior.API Example