Add non-erroring version/git-hash API to python_only_pip skeleton#29
Open
the-hampel wants to merge 1 commit into
Open
Add non-erroring version/git-hash API to python_only_pip skeleton#29the-hampel wants to merge 1 commit into
the-hampel wants to merge 1 commit into
Conversation
The pip skeleton only exposed package __version__; apps that consume the legacy version module (e.g. `from <app>.version import <app>_hash` in solid_dmft, recorded into output archives) would hit ImportError on a pip/PyPI install where no cmake-generated _version.py exists. Restore a public version.py submodule that works on both build paths: - TRIQS/cmake build: imports the real version + git hashes from the cmake-generated _version.py (now also carries triqs_hash/app_hash) - pip/PyPI install: reads the version from package metadata and uses an informative 'pypi-package-install' placeholder for the git hashes, so show_version()/show_git_hash() and <app>_hash imports never error __init__.py now sources __version__ from this single module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pip skeleton only exposed package version; apps that consume the legacy version module (e.g.
from <app>.version import <app>_hashin solid_dmft, recorded into output archives) would hit ImportError on a pip/PyPI install where no cmake-generated _version.py exists.Restore a public version.py submodule that works on both build paths:
init.py now sources version from this single module.