Stabilize ModuleDependency descriptions#1648
Open
DragonFSKY wants to merge 1 commit into
Open
Conversation
Sort class dependency descriptions before rendering a module dependency so the text remains stable across set iteration orders. Issue: TNG#1630 Signed-off-by: Dongliang Xie <dragonfsky@gmail.com>
DragonFSKY
force-pushed
the
fix-module-dependency-description-order
branch
from
40b2f28 to
f934965
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1630.
This makes
ModuleDependency#getDescription()render its underlying class dependencies in their naturalDependencyorder, instead of relying on the iteration order of the backing set. The collected dependencies are unchanged; only the textual report output is stabilized.A regression test verifies that the rendered description follows the same sorted dependency order.
Tested with: