wip: manage token page#1309
Draft
mvallenet wants to merge 14 commits into
Draft
Conversation
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
n0izn0iz
requested changes
Oct 22, 2024
n0izn0iz
left a comment
n0izn0iz
left a comment
Collaborator
There was a problem hiding this comment.
the screens prefix could use a rename but we can do that in a later PR
Comment on lines
+193
to
+204
| func GetUserTokensJSON(user string) string { | ||
| userAddr := std.Address(user) | ||
| var nodes []*json.Node | ||
| tokens.Iterate("", "", func(key string, value interface{}) bool { | ||
| token, _ := value.(*Token) | ||
| if token.admin.Owner() == userAddr { | ||
| nodes = append(nodes, token.ToJSON()) | ||
| } | ||
| return false | ||
| }) | ||
| return json.ArrayNode("", nodes).String() | ||
| } |
Collaborator
There was a problem hiding this comment.
we should index tokens by owner instead of iterating through all tokens here
| @@ -14,6 +14,18 @@ export const zodToken = z.object({ | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
why move this file here?
| return null; | ||
| } | ||
|
|
||
| const pmFeature = getNetworkFeature( |
Collaborator
There was a problem hiding this comment.
Suggested change
| const pmFeature = getNetworkFeature( | |
| const launchpadFeature = getNetworkFeature( |
Comment on lines
+31
to
+33
| const selectedWallet = useSelectedWallet(); | ||
| const caller = selectedWallet?.address; | ||
| const { data: tokens } = useUserTokens(networkId, caller || ""); |
Collaborator
There was a problem hiding this comment.
Suggested change
| const selectedWallet = useSelectedWallet(); | |
| const caller = selectedWallet?.address; | |
| const { data: tokens } = useUserTokens(networkId, caller || ""); | |
| const selectedWallet = useSelectedWallet(); | |
| const { data: tokens } = useUserTokens(selectedWallet?.userId); |
|
|
||
| export const useLastAirdrops = (networkId: string) => { | ||
| return useQuery(["lastAirdrops"], async () => { | ||
| return useQuery(["lastAirdrops", networkId], async () => { |
Collaborator
There was a problem hiding this comment.
Suggested change
| return useQuery(["lastAirdrops", networkId], async () => { | |
| return useQuery(["erc20LaunchpadLastAirdrops", networkId], async () => { |
we should use very explicit query keys prefixes to avoid conflicts in the future as these kind of conflicts are hard to pinpoint
| import { zodToken } from "@/utils/types/types"; | ||
|
|
||
| export const useUserTokens = (networkId: string, addr: string) => { | ||
| return useQuery(["userTokens", addr, networkId], async () => { |
| <ScreenContainer | ||
| headerChildren={<BrandText>Launchpad ERC 20</BrandText>} | ||
| forceNetworkFeatures={[NetworkFeature.LaunchpadERC20]} | ||
| forceNetworkKind={NetworkKind.Gno} |
Collaborator
There was a problem hiding this comment.
Suggested change
| forceNetworkKind={NetworkKind.Gno} |
don't need to force the network kind since you force based on features
Comment on lines
119
to
+120
| await queryClient.invalidateQueries(["lastTokens"]); | ||
| await queryClient.invalidateQueries(["userTokens"]); |
Collaborator
There was a problem hiding this comment.
why invalidate all networks
| component={LaunchpadERC20ManageTokenScreen} | ||
| options={{ | ||
| header: () => null, | ||
| title: screenTitle("Launchpad ERC20 Manage Token"), |
Collaborator
There was a problem hiding this comment.
Suggested change
| title: screenTitle("Launchpad ERC20 Manage Token"), | |
| title: screenTitle("Manage Fungible Token"), |
| LaunchpadERC20: undefined; | ||
| LaunchpadERC20Tokens?: { network?: string }; | ||
| LaunchpadERC20CreateToken: { step?: number }; | ||
| LaunchpadERC20ManageToken: { network?: string; token: Token }; |
Collaborator
There was a problem hiding this comment.
Suggested change
| LaunchpadERC20ManageToken: { network?: string; token: Token }; | |
| LaunchpadERC20ManageToken: { token: string }; |
we shouldn't use a networkId and a token object as screen params but instead a network-prefixed id that identifies this token (see getNetworkObjectId/parseNetworkObjectId) so we have a proper permalink
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Need review & help to ensure application of best pratices