fix for @minOccurs of 0 and @maxOccurs of 2 or more (but not "unbounded")
#774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#773. I am quite confident it fixes the problem identified in that issue, but does it break anything else?
sydb
requested review from
raffazizzi,
martindholmes,
ebeshero,
bleekere,
martinascholger and
joeytakeda
sydb
added
type: bug
This was referenced Sep 5, 2025
|
FWIW I could only reproduce this issue on Works on both dev and this branch:
|
raffazizzi
approved these changes
Sep 5, 2025
|
Tested using this odd file with @sydb and all looks well. test774odd.txt Looks like it is ready to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wow. We have been banging away at this for years, and I think we may finally have it right. (If you need convincing, see #135, #174, #354, and maybe #297.) This fix addresses #773.
I think if one or two people review this (at least in part by checking out this branch and trying some ODDs that have various
@minOccursand@maxOccuson various things) and find no problems, it is good to merge. (I.e., I do not think all 6 reviews need be in before merge.)