[#14360] Replace hard-coded query param keys - #14412
Open
aishwaryabandapelly-ai wants to merge 2 commits into
Open
[#14360] Replace hard-coded query param keys#14412aishwaryabandapelly-ai wants to merge 2 commits into
aishwaryabandapelly-ai wants to merge 2 commits into
Conversation
Author
|
All required checks are passing now. Please let me know if any changes are needed. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #14360.
This PR replaces remaining hard-coded shared backend query parameter keys in the frontend with the existing
QueryParamKeysconstants fromapi-const.ts.Changes
courseidusage withQueryParamKeys.COURSE_IDkeyusage withQueryParamKeys.KEYnextUrlusage withQueryParamKeys.NEXT_URLaccountidusage withQueryParamKeys.ACCOUNT_IDuseridusage withQueryParamKeys.USER_IDNotes
I intentionally left unrelated keys such as
entityType,instituteid, andstatusunchanged because they are not currently exposed inQueryParamKeysor are outside the scope of this small change.Testing
git diff --check