Fix compilation and runtime crashes on ESP32 core 3.x#389
Open
kevinagomez wants to merge 1 commit into
Open
Conversation
- Replace std::string with Arduino String throughout - Fix dangling pointer in onWrite() - Add null checks for BLE2902 descriptors (primary crash cause on core 3.x) - Tested on XIAO ESP32-C6 with Seeed core 3.3.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ESP32-BLE-Keyboard fails to compile and crashes at runtime on
ESP32 Arduino core 3.x (tested on XIAO ESP32-C6 with Seeed core 3.3.7).
Symptoms
Root Causes Fixed
(core 3.x returns nullptr from getDescriptorByUUID — this was the
primary crash cause)
Tested On