Additional QuantityArray constructions
#178
Open
+528
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icweaver
changed the title
QuantityArray constructions
Benchmark Results (Julia v1.10)Time benchmarks
Memory benchmarks
|
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
|
Hi @MilesCranmer, this PR should be ready for your review now. Two follow-up questions I had were:
|
|
Sweet, looks like this is working nicely with the new Makie PR: julia> using CairoMakie, DynamicQuantities
julia> x = [6, 7, 8]us"cm"
3-element QuantityArray(::Vector{Float64}, ::Quantity{Float64, SymbolicDimensions{FixedRational{Int32, 25200}}}):
6.0 cm
7.0 cm
8.0 cm
julia> y = (4:6)u"kg"
3-element QuantityArray(::StepRangeLen{Float64, Base.TwicePrecision{Float64}, Base.TwicePrecision{Float64}, Int64}, ::Quantity{Float64, Dimensions{FixedRational{Int32, 25200}}}):
4.0 kg
5.0 kg
6.0 kg
julia> scatter(x, y)
|
Actually, think I found a good balance, just pushed. Does this look alright to you? |
| @@ -364,6 +364,22 @@ julia> @btime $f.(qa) setup=(xa = randn(100000) .* u"km/s"; qa = QuantityArray(x | |||
|
|
|||
| So we can see the `QuantityArray` version saves on both time and memory. | |||
|
|
|||
| By default, DynamicQuantities will create a `QuantityArray` from an `AbstractArray`, similarly to how a `Quantity` is created from a scalar in the [Usage](@ref) examples: | |||
|
|
|||
| ```@repl quantity-array | |||
There was a problem hiding this comment.
Suggested change
| ```@repl quantity-array | |
| ```julia |
Since it will primarily be read via the README directly on github. Though maybe there could be a preprocessing stage before Documenter.jl build?
|
|
||
| This can be overridden to produce a vector of `Quantity`s by explicitly broadcasting the unit: | ||
|
|
||
| ```@repl quantity-array |
There was a problem hiding this comment.
Suggested change
| ```@repl quantity-array | |
| ```julia |
| @@ -281,6 +282,8 @@ f_square(v) = v^2 * 1.5 - v^2 | |||
| println("Applying function to y_q: ", sum(f_square.(y_q))) | |||
| ``` | |||
|
|
|||
| See [Home > Arrays](@ref home_arrays) for more. | |||
| @@ -0,0 +1,482 @@ | |||
|
|
|||
There was a problem hiding this comment.
I think this file got mistakenly committed. It is generated during the Documenter build
MilesCranmer
requested changes
Jul 14, 2025
|
Also re: your question, I think creating from generators is probably too much for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166
To-do