Skip to content

Propose OSS page#282

Merged
jaywonchung merged 8 commits intoSymbioticLab:developfrom
majunze2001:oss-page-jeffjma-v2
Mar 18, 2025
Merged

Propose OSS page#282
jaywonchung merged 8 commits intoSymbioticLab:developfrom
majunze2001:oss-page-jeffjma-v2

Conversation

@majunze2001
Copy link
Collaborator

Supported features:

  • Display both GitHub projects and non-GitHub projects. GitHub projects will display the repo details including language, the number of forks, and the number of stars fetched from the GitHub API.
  • Supports optional project logo.
  • Supports organizing projects into subsections with separate descriptions.

See source/oss/index.md for details.

- Integrated GitHub REST API with template CSS.
- See source/oss/index.md for details.
@mosharaf mosharaf requested a review from jaywonchung November 2, 2024 01:44
@jaywonchung
Copy link
Member

A screenshot would be helpful. Also, there is placeholder text in the body of the page, so I don't think this PR is intended to be merged yet.

@mosharaf
Copy link
Member

@majunze2001 Can you please restart this?

@jaywonchung
Copy link
Member

jaywonchung commented Mar 18, 2025

Screenshot 2025-03-18 at 4 14 40 PM @mosharaf This is what is looks like now. Project descriptions are based on their GitHub repo description. Please let us know the projects you'd like to have on the final page and I'll add those.

@mosharaf
Copy link
Member

I was just typing why the two boxes with and without icons have texts misaligned :)

@mosharaf
Copy link
Member

This looks very good for a start! Great work @majunze2001 @jaywonchung

@jaywonchung jaywonchung requested a review from mosharaf March 18, 2025 20:18
Copy link
Member

@mosharaf mosharaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, but looks good otherwise. I think we can iterate over the projects to include and texts to have over time.

@majunze2001 majunze2001 requested a review from mosharaf March 18, 2025 20:34
Copy link
Member

@mosharaf mosharaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@jaywonchung jaywonchung merged commit 1e3593d into SymbioticLab:develop Mar 18, 2025
1 check passed
@jaywonchung jaywonchung deleted the oss-page-jeffjma-v2 branch March 18, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants