Skip to content

Alias the workflow registry#695

Open
loic425 wants to merge 1 commit into
Sylius:poc-new-resource-metadatafrom
loic425:fix/alias-the-workflow-registry
Open

Alias the workflow registry#695
loic425 wants to merge 1 commit into
Sylius:poc-new-resource-metadatafrom
loic425:fix/alias-the-workflow-registry

Conversation

@loic425
Copy link
Copy Markdown
Member

@loic425 loic425 commented Apr 7, 2023

Q A
Bug fix? yes (will be)
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

See these different versions
5.4
6.1
6.2

On 6.2, the 'workflow.registry' is an alias of '.workflow.registry' instead of being the id itself.

@loic425 loic425 requested a review from a team as a code owner April 7, 2023 12:46
@vvasiloi
Copy link
Copy Markdown
Contributor

vvasiloi commented Jun 8, 2023

Is there a way to not use the registry and still provide a good DX?

@vvasiloi vvasiloi self-assigned this Jun 8, 2023
@vvasiloi
Copy link
Copy Markdown
Contributor

vvasiloi commented Jun 8, 2023

After discussing with @loic425 in private we came to the conclusion that we should try to avoid usage of the registry.
The alias was deprecated and the workflow registry is considered an internal service and it's usage is discouraged by the Symfony team.
Sources:

image

I'll come up with an alternative proposal to this PR.

@loic425 loic425 force-pushed the poc-new-resource-metadata branch 2 times, most recently from b5a7698 to 5ad1d7d Compare June 20, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👶 In review for the all core team

Development

Successfully merging this pull request may close these issues.

2 participants