Fix grid sorting bc break#372
Merged
NoResponseMate merged 1 commit intoMay 26, 2025
Merged
Conversation
Florian-Merle
commented
Apr 21, 2025
Comment on lines
26
to
34
| foreach ($gridConfiguration['sorting'] as $sorting => $order) { | ||
| Assert::keyExists($gridConfiguration['fields'] ?? [], $sorting); | ||
|
|
||
| if (isset($gridConfiguration['fields'][$sorting]['sortable'])) { | ||
| continue; | ||
| } | ||
|
|
||
| $gridConfiguration['fields'][$sorting]['sortable'] = true; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I'm wondering if using isset here is the right solution.
Looking at the tests, I had to update the line for the author because its sortable value was originally being changed from false to true. However, with these changes, that no longer happens.
Maybe the value should be set to true if it's either not set or currently false.
Member
There was a problem hiding this comment.
maybe should we throw an error that indicates the field is not sortable.
Florian-Merle
force-pushed
the
fix-grid-sorting-bc-break
branch
from
350f572 to
635f9b9
Compare
Member
|
@Florian-Merle Is this one ok for you? |
loic425
approved these changes
May 26, 2025
Member
|
@Florian-Merle I've tried the change on that grid and that fixes the issue. |
diimpp
approved these changes
May 26, 2025
NoResponseMate
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #369