fix ngrams constructor clash when word is constructor#2
Open
preynal wants to merge 1 commit intoSyeoryn:masterfrom
preynal:master
Open
fix ngrams constructor clash when word is constructor#2preynal wants to merge 1 commit intoSyeoryn:masterfrom preynal:master
preynal wants to merge 1 commit intoSyeoryn:masterfrom
preynal:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building ngrams from phrases with the word "constructor", I get unexpected behavior. This was because the dictionaries are created with
var x = {};which makes them inherit from the default object prototype with a constructor property. Creating an object with a null prototypeObject.create(null);solves the problem.