Skip to content

[Documentation:InstructorUI] Update current grade override view #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 1, 2025

Conversation

williamschen23
Copy link
Contributor

@williamschen23 williamschen23 commented Jun 27, 2025

Rename studentOveriden.png to studentOveridden.png. Changed most of the images to look like the current UI. Removed images/OverrideSelected.png as it is not being used.

Current:

Screen.Recording.2025-07-01.at.11.47.59.AM.mov

New:

Screen.Recording.2025-07-01.at.11.47.12.AM.mov

Copy link
Member

@bmcutler bmcutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes are good.

But I like the original images/TAOverriden1.png better than the replacement.

Overriding a non-student's grade is not the standard use case.
Also, I like the context with the override grade surrounded by other types of normal student grades.

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Jun 30, 2025
@williamschen23 williamschen23 requested a review from bmcutler July 1, 2025 15:51
@github-project-automation github-project-automation bot moved this from Work in Progress to Awaiting Maintainer Review in Submitty Development Jul 1, 2025
@bmcutler bmcutler merged commit 58acc8b into main Jul 1, 2025
4 checks passed
@bmcutler bmcutler deleted the grade-override branch July 1, 2025 16:22
@github-project-automation github-project-automation bot moved this from Awaiting Maintainer Review to Done in Submitty Development Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants